Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP][CORE] Add PullOutPreProject rule to decouple substrait pre-project #3649

Closed
wants to merge 1 commit into from
Closed

[WIP][CORE] Add PullOutPreProject rule to decouple substrait pre-project #3649

wants to merge 1 commit into from

Conversation

ulysses-you
Copy link
Contributor

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

(Fixes: #ISSUE-ID)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023

Run Gluten Clickhouse CI

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023

Run Gluten Clickhouse CI

@ulysses-you
Copy link
Contributor Author

/Benchmark Velox

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3649_time.csv log/native_master_11_07_2023_e3eff1d8f_time.csv difference percentage
q1 33.86 34.38 0.519 101.53%
q2 25.17 25.03 -0.147 99.42%
q3 37.83 38.14 0.319 100.84%
q4 37.02 37.57 0.549 101.48%
q5 71.35 71.50 0.154 100.22%
q6 7.94 6.26 -1.678 78.86%
q7 85.71 82.22 -3.490 95.93%
q8 87.10 86.95 -0.148 99.83%
q9 119.77 119.81 0.034 100.03%
q10 54.68 51.26 -3.414 93.76%
q11 20.11 19.73 -0.383 98.10%
q12 25.08 24.39 -0.689 97.25%
q13 48.45 50.30 1.848 103.81%
q14 20.09 17.67 -2.424 87.93%
q15 31.55 30.35 -1.196 96.21%
q16 16.09 16.20 0.108 100.67%
q17 100.29 101.51 1.219 101.22%
q18 148.19 148.26 0.069 100.05%
q19 14.71 16.17 1.464 109.96%
q20 34.16 30.31 -3.844 88.75%
q21 226.30 224.88 -1.419 99.37%
q22 13.28 14.08 0.809 106.09%
total 1258.72 1246.98 -11.742 99.07%

@ulysses-you
Copy link
Contributor Author

/Benchmark Velox

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3649_time.csv log/native_master_11_07_2023_e3eff1d8f_time.csv difference percentage
q1 33.89 34.38 0.489 101.44%
q2 25.63 25.03 -0.605 97.64%
q3 37.58 38.14 0.561 101.49%
q4 37.13 37.57 0.442 101.19%
q5 69.71 71.50 1.796 102.58%
q6 6.46 6.26 -0.204 96.84%
q7 83.15 82.22 -0.929 98.88%
q8 86.59 86.95 0.354 100.41%
q9 122.19 119.81 -2.382 98.05%
q10 52.55 51.26 -1.284 97.56%
q11 20.16 19.73 -0.428 97.88%
q12 26.72 24.39 -2.326 91.29%
q13 48.50 50.30 1.795 103.70%
q14 18.23 17.67 -0.567 96.89%
q15 31.96 30.35 -1.607 94.97%
q16 16.42 16.20 -0.216 98.68%
q17 102.46 101.51 -0.951 99.07%
q18 147.10 148.26 1.164 100.79%
q19 16.16 16.17 0.010 100.06%
q20 29.85 30.31 0.460 101.54%
q21 230.10 224.88 -5.217 97.73%
q22 13.26 14.08 0.829 106.26%
total 1255.80 1246.98 -8.817 99.30%

@FelixYBW
Copy link
Contributor

FelixYBW commented Nov 8, 2023

Title?

@ulysses-you
Copy link
Contributor Author

thank you @FelixYBW for the reminder. This pr is still working in process. I will refine it when it's ready.

@ulysses-you ulysses-you marked this pull request as draft November 9, 2023 01:44
@ulysses-you ulysses-you changed the title [WIP] [WIP][CORE] Add PullOutPreProject rule to decouple substrait pre-project Nov 9, 2023
@ulysses-you
Copy link
Contributor Author

/Benchmark Velox

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

Run Gluten Clickhouse CI

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3649_time.csv log/native_master_11_08_2023_29b58997a_time.csv difference percentage
q1 35.67 34.11 -1.560 95.63%
q2 25.23 25.13 -0.105 99.58%
q3 38.51 38.62 0.108 100.28%
q4 36.86 36.07 -0.788 97.86%
q5 69.43 71.84 2.412 103.47%
q6 7.95 7.59 -0.359 95.49%
q7 86.02 85.82 -0.205 99.76%
q8 86.38 86.97 0.597 100.69%
q9 122.54 121.86 -0.673 99.45%
q10 54.51 54.80 0.296 100.54%
q11 20.19 20.59 0.402 101.99%
q12 27.05 24.63 -2.420 91.06%
q13 50.44 49.95 -0.488 99.03%
q14 16.87 16.99 0.119 100.71%
q15 31.29 30.97 -0.321 98.97%
q16 16.18 16.51 0.328 102.03%
q17 100.93 102.40 1.466 101.45%
q18 148.50 148.28 -0.225 99.85%
q19 14.73 15.13 0.404 102.74%
q20 30.45 29.97 -0.475 98.44%
q21 225.78 222.20 -3.577 98.42%
q22 13.32 13.55 0.233 101.75%
total 1258.84 1254.01 -4.833 99.62%

@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added stale stale and removed stale stale labels Dec 25, 2023
@rui-mo rui-mo mentioned this pull request Jan 2, 2024
Closed
@zhztheplayer zhztheplayer mentioned this pull request Jan 24, 2024
Open
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale stale label Feb 14, 2024
@github-actions GitHub Actions
Copy link

This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks.

@github-actions github-actions bot closed this Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ulysses-you @GlutenPerfBot @FelixYBW